style: format Python sources and benchmark results - #408
Conversation
Signed-off-by: maxiaosong1124 <maxiaosong7890@outlook.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (41)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request applies formatting-only changes across benchmarks, examples, runtime integrations, kernels, and tests. It also adds the closing delimiter to one JSON result file. Runtime behavior and public interfaces remain unchanged. ChangesFormatting normalization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Merge Risk: ⚪ Minimal · up to This is a formatting-only change with no identified behavioral regression or merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 21.58% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 190 functions across 40 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Full-repository pre-commit checks encounter existing formatting violations on the main-branch baseline. Apply Black 24.4.2 formatting to 40 Python files, wrap long report strings without changing their values, and add the missing final newline to the ROCm benchmark results JSON.
Validation against base commit
6ceeb62:Black also normalizes mixed LF/CRLF endings in
tests/test_framework_runtime_adapters.py, accounting for much of that file's textual diff. Documentation, test assertions, type annotations, and CI configuration are unchanged.This PR is limited to formatting. Existing isort, Flake8, and MyPy issues remain unresolved, so the complete CI pipeline is not expected to pass yet. Related: #407.
Summary by CodeRabbit
Style
Chores