Skip to content

bugfix: Add empty choices field to streaming usage chunks - #1711

Merged
valarLip merged 1 commit into
ROCm:mainfrom
amd-youchen:bugfix-add-missing-choice-field
Jul 28, 2026
Merged

bugfix: Add empty choices field to streaming usage chunks#1711
valarLip merged 1 commit into
ROCm:mainfrom
amd-youchen:bugfix-add-missing-choice-field

Conversation

@amd-youchen

Copy link
Copy Markdown
Contributor

Motivation

The OpenAI API spec requires every streamed chunk to include a choices field. Our final usage-only chunks omitted it, causing strict clients (e.g. OpenAI Python SDK) to reject the response. This adds "choices": [] to all four usage chunk paths (chat/completion, single/fanout).

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1711 --add-label <label>

@zufayu
zufayu requested a review from valarLip July 28, 2026 01:44
@valarLip
valarLip merged commit e3cad0a into ROCm:main Jul 28, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants