You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Server: min_p is read as int, so fractional values (e.g. 0.05) become 0 #887
In configure_chat_engine_parameters (src/server/rest_handler.cpp, lines 814-816 at tag v1.0.11; same on main as of 2026-10-31):
if (has_value(request, "min_p")) {
int min_p = request["min_p"];
auto_chat_engine->set_minp(min_p);
}
set_minp takes a float (src/include/AutoModel/automodel.hpp:509), and the flm run path parses the value with std::stof (src/runner/runner.cpp:600). Because of the int, a usual value such as "min_p": 0.05 is truncated to 0 before it reaches the sampler, so min_p has no effect through the server API. In the same function, temperature and top_p are read as float.
Expected:float min_p = request["min_p"];
Found by reading the source; not checked at runtime.
Activity
tawei-amd commentedon Oct 31, 2026
Thanks @LalaDango for the clear report. Confirmed by reading the source:
int min_ptruncates fractional values to 0. Fix is up in #906 (float min_p).server: read min_p as float so fractional values are not truncated to 0
Merge pull request ROCm#906 from ROCm/fix/887-min-p-float