Repository navigation
ci: map the minicpm-v-4.7-moe engine to its catalog family - #897
Merged
Merged
Conversation
test_table_matches_catalog failed on main because the catalog family minicpm-v-4.7-moe was not named in the ENGINES table, so changes to its engine, headers or frontend would not select its CI suites. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tawei-amd
marked this pull request as ready for review
October 30, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`test_table_matches_catalog` in `.github/script/ci/test_changes.py` fails on main: the catalog family `minicpm-v-4.7-moe` is not named in the CI change-detection tables.
Fix
Add one `ENGINES` row mapping the `minicpm_v_4_7_moe` engine (and the `minicpm_v_moe` frontend spelling) to `minicpm-v-4.7-moe`. Changes to its engine library, headers or frontend now select its CI suites.
Testing
`python3 .github/script/ci/test_changes.py`: 17 tests, all pass (previously 1 failure on main at 1dcd364).
🤖 Generated with Claude Code