Skip to content

ci(wsl-rocdxg): build inside manylinux container via Docker in WSL#6359

Draft
dysu-amd wants to merge 5 commits into
mainfrom
users/dysu-amd/rocdxg-docker
Draft

ci(wsl-rocdxg): build inside manylinux container via Docker in WSL#6359
dysu-amd wants to merge 5 commits into
mainfrom
users/dysu-amd/rocdxg-docker

Conversation

@dysu-amd

@dysu-amd dysu-amd commented Jul 6, 2026

Copy link
Copy Markdown

Summary

Reworks the multi_arch_build_wsl_rocdxg_artifacts.yml workflow so librocdxg.so builds inside TheRock's manylinux Docker image via Docker in WSL, instead of directly in WSL.

Motivation

Running the build directly in the WSL environment meant building against glibc as provided by Ubuntu 24, which is newer than the glibc provided in TheRock's manylinux image. This could cause errors when linking rocdxg against libraries built with manylinux, which is most (if not all) of them. Building rocdxg inside the manylinux image would resolve this.

Should resolve #6245

Changes

  • Containerized configure & build stages. The Configure and Build stage steps now docker run the pinned manylinux image (MANYLINUX_IMAGE, referenced by digest), bind-mounting the workspace and build dir with src==dst so the in-container cmake invocation matches a native WSL one. Inside the container it installs requirements.txt (+ any staged pip deps), then runs the same cmake configure/build.
  • Docker-in-WSL bring-up. New Start Docker in WSL step launches dockerd detached (no init system under WSL2), polls docker info until the socket is ready, and pulls the image. WSL additional-packages trimmed to docker.io python3 python3-pip python3-psutil python3-venv — the C/C++ toolchain now lives in the container.
  • Windows SDK mounting. The SDK shared-include dir is bind-mounted read-only at a clean, space-free path (THEROCK_WSL_WIN_SDK_MOUNT=/opt/winsdk-shared) and passed via -DTHEROCK_WSL_WIN_SDK, replacing the previous host-side symlink workaround for the (x86) path segment. WSLENV extended to propagate MANYLINUX_IMAGE and the mount path.

Test plan

  • Ensure the rocdxg WSL CI passes.
  • Ensure other relevant CI passes.

@therock-pr-bot

therock-pr-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 6, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@schundu007

This comment was marked as spam.

@dysu-amd dysu-amd reopened this Jul 10, 2026
@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Issue]: ROCm SDK tests fail with GLIBCXX_3.4.32 not found and testSharedLibrariesLoad error when loading librocdxg.so (Python 3.11)

2 participants