ci(wsl-rocdxg): build inside manylinux container via Docker in WSL#6359
Draft
dysu-amd wants to merge 5 commits into
Draft
ci(wsl-rocdxg): build inside manylinux container via Docker in WSL#6359dysu-amd wants to merge 5 commits into
dysu-amd wants to merge 5 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This comment was marked as spam.
This comment was marked as spam.
e34613d to
d98348f
Compare
962c8fa to
9165e6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the multi_arch_build_wsl_rocdxg_artifacts.yml workflow so librocdxg.so builds inside TheRock's manylinux Docker image via Docker in WSL, instead of directly in WSL.
Motivation
Running the build directly in the WSL environment meant building against glibc as provided by Ubuntu 24, which is newer than the glibc provided in TheRock's manylinux image. This could cause errors when linking rocdxg against libraries built with manylinux, which is most (if not all) of them. Building rocdxg inside the manylinux image would resolve this.
Should resolve #6245
Changes
docker runthe pinned manylinux image (MANYLINUX_IMAGE, referenced by digest), bind-mounting the workspace and build dir with src==dst so the in-container cmake invocation matches a native WSL one. Inside the container it installs requirements.txt (+ any staged pip deps), then runs the same cmake configure/build.Test plan