revert(hipdnn): remove Python bindings from TheRock by tvy-amd · Pull Request #6425 · ROCm/TheRock

tvy-amd · 2026-07-08T17:31:56Z

Summary

We thought hipDNN bindings were going to land in TheRock artifacts, but the new artitecture is that we are going to have a different repo for all bindings.
So, this PR reverts TheRock-side hipDNN Python binding build, packaging, and wheel-validation CI wiring added by PR #5429, so binding-specific CI can move out of TheRock per ALMIOPEN-2285. JIRA ID : ALMIOPEN-2285

Risk Assessment

Medium risk. The user risk hint was low, but this changes hipDNN build, package, and test infrastructure by removing TheRock Python binding paths; local test-matrix unit coverage and formatting checks passed, with PR CI still needed for build and artifact validation.

ASIC Coverage

Standard PR CI is sufficient. This is ASIC-independent build, CI, and artifact packaging cleanup that removes hipDNN Python binding wiring from TheRock; it does not change kernels, provider support surface, dispatch behavior, or GPU defaults, so no dedicated multi-arch sweep is required.

Testing Summary

Local Python unit coverage validates CI test-matrix generation after removing the hipDNN Python bindings job entry.
Local formatting validation confirmed the changed Python files are Black-compliant.
Reference search confirmed no remaining nanobind, robin-map, therock-nanobind, or therock-robin-map references in touched TheRock build/test areas.
PR CI is pending and must validate the CMake, artifact packaging, and repository pre-commit effects.

Testing Checklist

Test matrix unit tests - python -m unittest build_tools.github_actions.tests.fetch_test_configurations_test - Status: Passed
Python formatting - python -m black --check build_tools/github_actions/tests/fetch_test_configurations_test.py - Status: Passed
Dependency reference check - Search for nanobind, robin-map, therock-nanobind, and therock-robin-map references - Status: Passed
PR CI - GitHub PR checks - Status: Pending

Technical Changes

Removes the disabled hipDNN Python bindings CI matrix entry and deletes the wheel-packaging and frontend pytest scripts from TheRock.
Stops configuring hipDNN with Python bindings enabled and removes TheRock build dependencies only needed by that bindings path.
Removes share/hipdnn/python/** artifact include/exclude rules and the shared loader-environment helper used only by the deleted Python binding test.
Removes the now-unused third-party/nanobind and third-party/robin-map CMake subprojects from the third-party build list.
Keeps the required companion test-file change non-functional; no new test behavior is added.

…heel validation test, and CI matrix entry (#5429)" This reverts commit f6069c3.

therock-pr-bot · 2026-07-08T17:32:21Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
🌿 Branch Name	✅ Pass	—
📝 PR Title/Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

therock-pr-bot · 2026-07-08T17:32:23Z

🎉 All checks passed! This PR is ready for review.

therock-pr-bot · 2026-07-08T17:50:40Z

Pre-commit check failed

⛔ pre-commit failed

Please run locally:

python -m pip install pre-commit
pre-commit install
pre-commit run --all-files --show-diff-on-failure

This repo uses .pre-commit-config.yaml.

tvy-amd · 2026-07-08T18:35:27Z

-therock_subproject_fetch(therock-nanobind-sources
-  CMAKE_PROJECT
-  # Originally mirrored from: https://github.com/wjakob/nanobind/archive/refs/tags/v2.12.0.tar.gz
-  URL https://rocm-third-party-deps.s3.us-east-2.amazonaws.com/nanobind-2.12.0.tar.gz


I'll ask to remove these artifacts after this PR is in

Did we double check no one else is using these since they were added?

Double checked in TheRock and doesn't seem like anyone is using this

Right now it is unused but even if we move the hipDNN bindings to a separate repo (and eventually we have more than one?), do you intend to build nanobind there or should TheRock provide these deps?

I think it makes sense to keep the artifacts uploaded, and use those until it's clear where the new final home is.

I believe TheRock shouldn't provide the dependencies; since in the future it will be rocm-libraries ->TheRock->rocm-bindings. If it did, it would cause a cycle dependencies.

So mostly likely rocm-bindings will build nanobind.

I will keep the artifacts around in s3 then

BrianHarrisonAMD

Looks good, but we need to double check no one else started depending on the 3rd party deps, or any of the common scripts we added.

If they are confirmed fully dead code, then we should be good to remove.

geomin12

i see build failures. don't seem unrelated, so worth a retry

i also agree Brian, we should make sure this builds all properly and double check that no components use this. a search should solve that though

marbre · 2026-07-10T10:39:28Z

      "-DHIP_DNN_SKIP_TESTS=$<NOT:$<BOOL:${THEROCK_BUILD_TESTING}>>"
      -DHIP_DNN_BUILD_PLUGINS=OFF
      -DHIP_DNN_GENERATE_SDK_HEADERS=OFF
-      -DHIPDNN_BUILD_PYTHON_BINDINGS=ON


Should this be rather set explicitly to OFF?

I'm actually removing this option in rocm-libraries. It is defaulted off so it's fine to remove here.

marbre · 2026-07-10T10:40:42Z

-therock_subproject_fetch(therock-nanobind-sources
-  CMAKE_PROJECT
-  # Originally mirrored from: https://github.com/wjakob/nanobind/archive/refs/tags/v2.12.0.tar.gz
-  URL https://rocm-third-party-deps.s3.us-east-2.amazonaws.com/nanobind-2.12.0.tar.gz


Right now it is unused but even if we move the hipDNN bindings to a separate repo (and eventually we have more than one?), do you intend to build nanobind there or should TheRock provide these deps?

tvy-amd added 2 commits July 8, 2026 11:07

Revert "[hipDNN] ALMIOPEN-1869 Enable hipDNN Python bindings build, w…

04f1bb6

…heel validation test, and CI matrix entry (#5429)" This reverts commit f6069c3.

more undos

d591cf9

github-project-automation Bot added this to TheRock Triage Jul 8, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Jul 8, 2026

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 8, 2026

test: cover removed hipdnn bindings CI label

7878ee7

style: format hipdnn CI revert

ca023fe

therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 8, 2026

build: remove unused hipdnn binding dependencies

87766b5

tvy-amd commented Jul 8, 2026

View reviewed changes

Comment thread third-party/nanobind/CMakeLists.txt Outdated

tvy-amd commented Jul 8, 2026

View reviewed changes

test: replace hipdnn label test with blank change

6aaa6ce

tvy-amd commented Jul 8, 2026

View reviewed changes

Comment thread build_tools/github_actions/test_executable_scripts/libhipcxx_utils.py

tvy-amd commented Jul 8, 2026

View reviewed changes

Comment thread build_tools/github_actions/test_executable_scripts/hipdnn/pack_frontend_wheel.py Outdated

tvy-amd marked this pull request as ready for review July 8, 2026 19:02

tvy-amd requested review from ScottTodd, geomin12 and marbre and removed request for ScottTodd and geomin12 July 8, 2026 19:03

BrianHarrisonAMD reviewed Jul 8, 2026

View reviewed changes

Comment thread build_tools/github_actions/tests/fetch_test_configurations_test.py

BrianHarrisonAMD approved these changes Jul 8, 2026

View reviewed changes

tvy-amd added 2 commits July 9, 2026 08:25

Merge branch 'main' into users/tvy/revert-hipdnn-python-bindings

93ec5d6

Merge branch 'main' into users/tvy/revert-hipdnn-python-bindings

045ebac

geomin12 reviewed Jul 9, 2026

View reviewed changes

marbre reviewed Jul 10, 2026

View reviewed changes

Merge branch 'main' into users/tvy/revert-hipdnn-python-bindings

471b9cc

Uh oh!

Conversation

tvy-amd commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Risk Assessment

ASIC Coverage

Testing Summary

Testing Checklist

Technical Changes

Uh oh!

therock-pr-bot Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

therock-pr-bot Bot commented Jul 8, 2026

Pre-commit check failed

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tvy-amd commented Jul 8, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 8, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 8, 2026 •

edited

Loading