feat: Catch incomplete Python package sets#6433
Open
marbre wants to merge 2 commits into
Open
Conversation
Kpack-split Python package builds could succeed even when the fetched artifact catalog did not contain every device target advertised for the platform. That allowed nightly releases to publish an incomplete set of rocm-sdk-device wheels without failing the workflow. With this patch, the package build will fail when advertised device targets are missing so incomplete sets of device packages are caught before upload. Assisted-by: Codex <codex@openai.com>
Kpack-split package builds could leave a publishable dist directory without required runtime and meta packages, allowing upload to proceed with an incomplete ROCm Python package set. This patch implements verifying that the final dist output includes the ROCm meta sdist, core and libraries wheels, each expected current-platform device wheel, and the devel wheel (for the case that dev artifacts have been fetched). Assisted-by: Codex <codex@openai.com>#
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Kpack-split Python package builds could succeed even when the fetched
artifact catalog did not contain every device target advertised for the
platform.
Furthermore, kpack-split package builds could leave a publishable dist
directory without required runtime and meta packages, allowing upload
to proceed with an incomplete ROCm Python package set.
Technical Details
Let the package build fail when advertised device targets are missing so
incomplete sets of device packages are caught before upload.
Furthermore, verifies that the final dist output includes the ROCm meta
sdist, core and libraries wheels, each expected current-platform device
wheel, and the devel wheel (for the case that dev artifacts have been
fetched).
Closes #6422.
Submission Checklist