Skip to content

docs: fix stale GPU project exclusion issue links#6444

Open
GrecAndrei wants to merge 1 commit into
ROCm:mainfrom
GrecAndrei:users/grecandrei/fix-gpu-exclusion-refs
Open

docs: fix stale GPU project exclusion issue links#6444
GrecAndrei wants to merge 1 commit into
ROCm:mainfrom
GrecAndrei:users/grecandrei/fix-gpu-exclusion-refs

Conversation

@GrecAndrei

Copy link
Copy Markdown
Contributor

Summary

Exclusion audit for cmake/therock_amdgpu_targets.cmakecomments and issue links only, no enable/disable behavior change.

Why

People (rightly) assume “Build Passing ✅” means libraries are on. The exclude list is where that diverges from CUDA. Wrong issue links make the gap look fixed when it isn’t, or fixed when it still isn’t supported.

Changes

Item Before After
composable_kernel on gfx103x linked #4836 (MIOPEN mixed-arch flag; closed/fixed) #1245 (CK actually unsupported on these arches)
rocWMMA on gfx10 and below bare link to #1944 (closed) Comment: no official support below gfx11; closed as not planned
gfx1033 composable_kernel no issue link #1245
Policy none Short note: closed “won’t support” still needs exclude; closed “fixed” should remove exclude after verify

Explicitly not removed

Test plan

  • Diff is comments only
  • No CMake logic / exclude membership changes (except clarifying existing rows)

- Point composable_kernel excludes at ROCm#1245 (CK unsupported arches), not
  ROCm#4836 (MIOPEN mixed-arch flag, already fixed)
- Clarify rocWMMA excludes: ROCm#1944 closed as not planned for gfx10 and below
- Link bare composable_kernel exclude on gfx1033
- Document exclusion policy at the top of the target table

No functional enable/disable changes — comments and issue links only.
Copilot AI review requested due to automatic review settings July 9, 2026 10:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@therock-pr-bot

therock-pr-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants