ci: dispatch full PyTorch tests for dev releases#6449
Draft
ethanwee1 wants to merge 1 commit into
Draft
Conversation
Let release_type == dev dispatch the full PyTorch test suite in addition to nightly. The package index URL is already derived from the build/publish step output (MULTI_ARCH_INDEX_URLS[release_type]), so dev runs test against the dev index (rocm.devreleases.amd.com) automatically. Dev builds are on-demand and only reach the dispatch job when run_full_pytorch_tests is set, so they bypass the nightly weekly-cadence gate and dispatch whenever requested. Closes #5781
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets
devreleases dispatch the full PyTorch test suite (in addition tonightly) from the per-ref build workflow (multi_arch_build_portable_linux_pytorch_wheels.yml).Closes #5781.
Context
This replaces #5815, which was stacked on the now-closed #5813 branch and edited
the pre-#5780 dispatch location in
multi_arch_release_linux_pytorch_wheels.yml.After #5780 the full-test dispatch lives in the build workflow's
dispatch_pytorch_wheels_full_testjob, so the change is now a small, focusededit there.
Of #5781's two asks:
main: the dispatch passespackage_index_url: ${{ needs.build_pytorch_wheels.outputs.package_index_url }},which is derived from the publish step (
MULTI_ARCH_INDEX_URLS[release_type]).For
devthat resolves tohttps://rocm.devreleases.amd.com/whl-multi-arch/.devto the dispatch gate.What changed
dispatch_pytorch_wheels_full_testgate now acceptsrelease_type == 'nightly' || release_type == 'dev'.devas on-demand: dev builds only reach this job whenrun_full_pytorch_testsis set, so they dispatch whenever requested rather thanbeing subject to the nightly weekly (Sunday) cadence.
Cadence / safety
Safe no-op for dev until a scheduled/dispatched build passes
run_full_pytorch_tests=truefor a dev release — the dispatch only fires whenthat flag is set, so routine on-demand dev builds do not trigger a full-test
storm.