fix(ci): Add build_variant to Test Artifacts run-name#6459
Open
geomin12 wants to merge 2 commits into
Open
Conversation
Include the build_variant (release/asan) in the workflow run-name to easily distinguish between regular and ASAN test artifact runs. Fixes #6456 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
marbre
requested changes
Jul 9, 2026
marbre
left a comment
marbre
left a comment
Member
There was a problem hiding this comment.
Checking the input in the test jobs linked in the issue both jobs show build_variant: release. Thus, this doesn't help to distinguish between non-ASAN and ASAN.
The test_artifacts run-name now includes build_variant, but the multi_arch_release_linux workflow wasn't passing it through when triggering test_artifacts. This caused ASAN builds to still show "release" instead of "asan" in the job name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the build_variant (release/asan) in the workflow run-name to easily distinguish between regular and ASAN test artifact runs.
Closes #6456
Working here: https://github.com/ROCm/TheRock/actions/runs/29054942544