fix(bump): create next bump PR immediately after merge#6463
Draft
amd-chiranjeevi wants to merge 2 commits into
Draft
fix(bump): create next bump PR immediately after merge#6463amd-chiranjeevi wants to merge 2 commits into
amd-chiranjeevi wants to merge 2 commits into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The bump automation runs on a 12-hour cron schedule (0 */12 * * *). When a bump PR (e.g. bump-rocm-systems-abc1234) merges into main, the next bump PR is not created until the next scheduled
run — up to 12 hours later. This creates an unnecessary lag in the integration cycle and means CI on the next bump sits idle for half a day.
The push event on main already fires when a bump PR merges, and handle_push already does useful work (closes stale PRs, updates refs in rocm-systems/rocm-libraries). It's the natural place to
also kick off the next bump PR immediately.
JIRA ID: N/A
Files Changed
Expected Test Results
rocm-systemsmerges intomainpushtrigger fires →handle_pushruns → stale PRs closed → refs updated inrocm-systems→ new bump PRbump-rocm-systems-<new-sha>created immediatelyrocm-librariesmerges intomainrocm-librariescreate_therock_bumpfails (e.g. API error)[WARN] create_therock_bump failed: <error>logged, workflow exits 0, ref update PR still createdhandle_schedulestill workscreate_therock_bumpdirectly, decorator is transparent on successTest Result
Submission Checklist