Skip to content

fix(bump): create next bump PR immediately after merge#6463

Draft
amd-chiranjeevi wants to merge 2 commits into
mainfrom
users/amd-chiranjeevi/update_bump_automation
Draft

fix(bump): create next bump PR immediately after merge#6463
amd-chiranjeevi wants to merge 2 commits into
mainfrom
users/amd-chiranjeevi/update_bump_automation

Conversation

@amd-chiranjeevi

@amd-chiranjeevi amd-chiranjeevi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Motivation

The bump automation runs on a 12-hour cron schedule (0 */12 * * *). When a bump PR (e.g. bump-rocm-systems-abc1234) merges into main, the next bump PR is not created until the next scheduled
run — up to 12 hours later. This creates an unnecessary lag in the integration cycle and means CI on the next bump sits idle for half a day.

The push event on main already fires when a bump PR merges, and handle_push already does useful work (closes stale PRs, updates refs in rocm-systems/rocm-libraries). It's the natural place to
also kick off the next bump PR immediately.

JIRA ID: N/A

Files Changed

  • build_tools/github_actions/bump_automation.py — 24 lines added

Expected Test Results

Scenario Expected
Bump PR for rocm-systems merges into main push trigger fires → handle_push runs → stale PRs closed → refs updated in rocm-systems → new bump PR bump-rocm-systems-<new-sha> created immediately
Bump PR for rocm-libraries merges into main Same as above for rocm-libraries
create_therock_bump fails (e.g. API error) [WARN] create_therock_bump failed: <error> logged, workflow exits 0, ref update PR still created
handle_schedule still works Unaffected — schedule path calls create_therock_bump directly, decorator is transparent on success

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/github_actions/bump_automation.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 10, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@amd-chiranjeevi amd-chiranjeevi changed the title fix(bump): Create next bump PR immediately after merge instead of waiting for schedule fix(bump): Create next bump PR immediately after merge instead of waiting for schedule Jul 10, 2026
@amd-chiranjeevi amd-chiranjeevi changed the title fix(bump): Create next bump PR immediately after merge instead of waiting for schedule fix(bump): create next bump PR immediately after merge Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant