feat(ccache): add opt-in in-cluster Redis remote backend#6468
Draft
subodh-dubey-amd wants to merge 2 commits into
Draft
feat(ccache): add opt-in in-cluster Redis remote backend#6468subodh-dubey-amd wants to merge 2 commits into
subodh-dubey-amd wants to merge 2 commits into
Conversation
Adds a github-oss-redis preset to setup_ccache.py and threads an opt-in cache_type=ccache-redis through the multi-arch Linux CI workflows. Default remains sccache. Redis is deployed in-cluster via ROCm/TheRock-Infra. Co-authored-by: Cursor <cursoragent@cursor.com>
- mdformat: fix table whitespace in ccache_troubleshooting.md - black: wrap long line in setup_sccache_rocm.py (pre-existing, flagged by --all-files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
users/subodh-dubey-amd/sccache-mathlibs-debug(it carries thecache_typeplumbing this builds on). Retarget tomainonce that lands.Summary
build_tools/setup_ccache.py: newgithub-oss-redispreset pointing at the in-cluster Redis service (redis://redis-ccache-svc.redis-ccache-ns.svc.cluster.local:6379), overridable viaCCACHE_REDIS_ENDPOINT. bazel-remote presets unchanged.cache_type=ccache-redisthroughmulti_arch_ci.yml→multi_arch_ci_linux.yml→multi_arch_build_portable_linux.yml→ artifacts, which gains accache-redisbranch (redis preset + ccache launcher flags + stats). Default stayssccache.cache_typeto thestorage-libsstage (was missing).ccache_troubleshooting.mddocuments the backend + corrects the stale "ccache is the default" note.Infra (Redis deploy) is in ROCm/TheRock-Infra#416.
Notes
aws-linux-scale-rocm-prod. Windows/sanitizer (Azure) can use it once they move into the AWS cluster.Test plan
workflow_dispatchMulti-Arch CI on this branch withcache_type=ccache-redis,linux_amdgpu_families=gfx94X.ccache -s -v); compare vs sccache.