fix(rocprofiler-systems): Allow MPI tests to function#6475
Draft
kcossett-amd wants to merge 2 commits into
Draft
fix(rocprofiler-systems): Allow MPI tests to function#6475kcossett-amd wants to merge 2 commits into
kcossett-amd wants to merge 2 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Jira ID: AIPROFSYST-524
Note: I'm not enabling these tests to run on TheRock CI. I'm just fixing things so that if someone were to build with
THEROCK_ENABLE_MPI, then these tests would pass.MPI tests were originally disabled as if I build with
THEROCK_ENABLE_MPI, then all mpi tests would fail with:Open MPI bakes its build-time install prefix (
/therock/output/...from themanylinuxcontainer) into its binaries as string literals. Outside the container that path doesn't exist, so plugin discovery fails (prterun-exec-failed) and even the error message can't be looked up (help-mpirun.txt: No such file or directory).Technical Details
Open MPI 5.x is three independently-prefixed layers (OMPI/OPAL, the PRRTE launcher, and PMIx), each with its own override env var. Setting these (
OPAL_PREFIX,PRTE_PREFIX,PMIX_PREFIX) torocm_path(the real install root) relocates every layer's file lookups to where the files actually are.Test Plan
Manual Testing
Test Result
Locally, all tests pass.
Submission Checklist