Add a switch to determine which hostcall implementation to build#6481
Open
b-sumner wants to merge 1 commit into
Open
Add a switch to determine which hostcall implementation to build#6481b-sumner wants to merge 1 commit into
b-sumner wants to merge 1 commit into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
lamb-j
approved these changes
Jul 11, 2026
lamb-j
left a comment
Contributor
There was a problem hiding this comment.
LGTM, note this is a temporary option.
Once the two commits come in via SMP updates to llvm-project and ROCm-systems, and prove to be stable, we can remove this option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Temporary switch to enable the new hostcall version before fully commiting it
Technical Details
Adds a new THEROCK cmake variable and propagates it to the submodules using it.
Test Plan
Build with variable set to OFF and ON
Test Result
Verified correct build operation
Submission Checklist
Pre-req: ROCm/llvm-project#3311 and ROCm/rocm-systems#8409