Skip to content

chore(compiler): set submodule pointer for Compiler comgr hotspot July 10#6482

Draft
ronlieb wants to merge 4 commits into
mainfrom
users/rlieberm/therock-hotswap-cherrypick-v5
Draft

chore(compiler): set submodule pointer for Compiler comgr hotspot July 10#6482
ronlieb wants to merge 4 commits into
mainfrom
users/rlieberm/therock-hotswap-cherrypick-v5

Conversation

@ronlieb

@ronlieb ronlieb commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

llvm 44cf65f2b22d
unchanged:
hipify 6acec775
spirv fb08e83a

JIRA ID : https://amd.atlassian.net/browse/PLAT-204991

HotSwap CP's:
44cf65f2b22d [Comgr][hotswap] Include TargetParser.h instead of AMDGPUTargetParser.h
47e1666fbe02 [AMDGPU] comgr: wrap long comment lines to 80 columns
e1a289619a05 [AMDGPU] comgr: trim stochastic rounding comment per review
beaee8b8a602 [AMDGPU] comgr: update SR FP8 modifier lit test for carry-propagation fix
163263b6eb1e [AMDGPU] comgr: fix SR FP8 carry-propagation in E5M3 stochastic rounding
eaf7aa50eef6 AMDGPU: apply gfx1250 hotswap mask workarounds
16747b94d6f7 AMDGPU: add strict hotswap rewrite plumbing
da719ba90d98 [Comgr][hotswap] Decline far s_add_pc_i64 trampolines (#3305)
bf22f159a259 [Comgr][hotswap] Append trampoline pool at a fresh vaddr instead of shifting post-.text addresses/symbols (#3252)
1fd9716efbfd AMDGPU: scope hotswap trampolines and clamp entry prefetch (#3195)
86ed6b0d0f30 AMDGPU: support literal sources in FP8 pack hotswap (#3189)
924aef5ab523 AMDGPU: reduce hotswap helper duplication (#3138)
dc4032f75353 AMDGPU: guard hotswap entry stub idempotency decode (#3182)
a42b456a38e2 [Comgr][hotswap] Fix scratch VGPR misallocation and fail safe on branch overflow (#3137)
d0d7a4a1040a AMDGPU: add hotswap entry trampoline core (#3008)

Build fix: 44cf65f2b22d retargets the comgr-hotswap include to TargetParser.h (where IsaVersion/getIsaVersion live at this base). The split-out AMDGPUTargetParser.h (upstream PR #198433) is not present here. Revert once the amd-llvm pin advances past that split.

llvm   47e1666fbe02
unchanged:
hipify 6acec775
spirv  fb08e83a

JIRA ID : https://amd.atlassian.net/browse/PLAT-204991

HotSwap CP's:
47e1666fbe02 [AMDGPU] comgr: wrap long comment lines to 80 columns
e1a289619a05 [AMDGPU] comgr: trim stochastic rounding comment per review
beaee8b8a602 [AMDGPU] comgr: update SR FP8 modifier lit test for carry-propagation fix
163263b6eb1e [AMDGPU] comgr: fix SR FP8 carry-propagation in E5M3 stochastic rounding
eaf7aa50eef6 AMDGPU: apply gfx1250 hotswap mask workarounds
16747b94d6f7 AMDGPU: add strict hotswap rewrite plumbing
da719ba90d98 [Comgr][hotswap] Decline far s_add_pc_i64 trampolines (#3305)
bf22f159a259 [Comgr][hotswap] Append trampoline pool at a fresh vaddr instead of shifting post-.text addresses/symbols (#3252)
1fd9716efbfd AMDGPU: scope hotswap trampolines and clamp entry prefetch (#3195)
86ed6b0d0f30 AMDGPU: support literal sources in FP8 pack hotswap (#3189)
924aef5ab523 AMDGPU: reduce hotswap helper duplication (#3138)
dc4032f75353 AMDGPU: guard hotswap entry stub idempotency decode (#3182)
a42b456a38e2 [Comgr][hotswap] Fix scratch VGPR misallocation and fail safe on branch overflow (#3137)
d0d7a4a1040a AMDGPU: add hotswap entry trampoline core (#3008)
@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@ronlieb ronlieb changed the title set submodule pointer for Compiler comgr hotspot July 10 chore(compiler): set submodule pointer for Compiler comgr hotspot July 10 Jul 10, 2026
@rahulc-gh rahulc-gh added the gfx125x Issue/PR relates to gfx125x family label Jul 10, 2026

@searlmc1 searlmc1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Advances compiler/amd-llvm 47e1666fbe02 -> 44cf65f2b22d, adding the
comgr-hotswap TargetParser.h include fix so the compiler-runtime stage
builds without the missing AMDGPUTargetParser.h header.

JIRA ID : PLAT-204991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gfx125x Issue/PR relates to gfx125x family

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

5 participants