chore(rocm): align devcontainer Dockerfile with pyproject deps#253
Merged
demandal25 merged 2 commits intoJun 15, 2026
Merged
Conversation
Add pytest-rerunfailures (needed by the --reruns test command), pin scikit-build-core>=0.4.3 and setuptools-scm>=9.2 to match [build-system], switch torch install from -f to --index-url to prevent silently pulling a CPU-only wheel from PyPI, and uppercase the FROM ... AS alias. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the ROCm devcontainer Dockerfile so its Python environment matches the repository’s declared dev/build dependencies and installs the ROCm PyTorch wheel in a safer way (avoiding accidental CPU-only wheels).
Changes:
- Add
pytest-rerunfailuresto the devcontainer image to matchpyproject.toml’sdevextras and the documented pytest command. - Align build tooling constraints by pinning
scikit-build-core>=0.4.3andsetuptools-scm>=9.2to match[build-system].requires. - Install
torchusing--index-url https://repo.radeon.com/...(instead of-f) and fixFROM ... AScasing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the ROCm devcontainer Dockerfile in line with
pyproject.tomlso thebuilt image satisfies every requirement out of the box, and fix a latent torch
install hazard.
What changed
.devcontainer/rocm/Dockerfilepytest-rerunfailures— required by the documented test command(
pytest -n auto --reruns 2) and listed under[project.optional-dependencies].dev; it was the only outright missing dep.scikit-build-core>=0.4.3andsetuptools-scm>=9.2to match theconstraints in
[build-system].requires.-fto--index-url. BothCLAUDE.mdandREADME.mdwarn that-flets pip silently fall back to a CPU-only wheelfrom PyPI;
--index-urlpins the resolver to AMD's ROCm repo.FROM ... ASto silence BuildKit'sFromAsCasinglint warning.Test plan
docker buildarg surface unchanged (ROCM_VERSION / PY_VERSION / TORCH_VERSION / AITER_VERSION)pre-commit run -a(passed on commit)