Repository navigation
ci(oga): apply the Qwen3.8 runtime via microsoft/onnxruntime-genai#2801 - #1335
Merged
Merged
Conversation
|
Thanks for opening a PR! This project follows LLVM's incremental-development and AI-tool-use Before requesting review, please check that:
Reviewers are assigned through |
L2 Accuracy Results (EP vs CPU)
Threshold: 0.01 | Run: 8027 - Commit: |
Binary sizesBaseline: run 40617608668 -
MorphiZen EP Performance Results
EPContext Export Performance
EPContext Import Performance
OGA Benchmark Results
OGA Wheel Smoke (Python benchmark_e2e.py)
VLM Benchmark Results
TTFT / TPS vs mainBaseline: run 40617608668 -
Run: 8027 - Commit: |
zz002
force-pushed
the
ci/oga-qwen38-patch-chain
branch
from
October 27, 2026 03:15
997af3f to
abe16d2
Compare
zz002
requested review from
CaymanYang,
amd-bqiao,
amd-mingw,
asparkhi,
edelaye,
fhanuman,
qianglin-amd,
sambanerxilinxamd and
wcy123
as code owners
October 27, 2026 12:37
1 of 3 tasks
zz002
added a commit
that referenced
this pull request
Oct 28, 2026
## Summary Replace the 42-PR OGA patch list used for Qwen3.8-Flash-Next with the existing patches plus two: microsoft/onnxruntime-genai#2792 (onnxruntime-extensions pin with `Qwen3_5Tokenizer`) and microsoft/onnxruntime-genai#2801 (Qwen3.8 runtime from #2714 plus the IndexerCache fix #2782, ported onto v0.17.0). CI vehicle stacked on #1335; not for merge. ## Related issue or design Stacked on #1335. ## Why The previous list applied #2713/#2714 together with 35 OGA main PRs they depend on, which moved a large part of OGA past v0.17.0. #2801 ports only the Generator-path runtime onto v0.17.0, so the OGA used by CI stays close to the release. ## What - `windows-deps.yml`, `linux-build.yml`: `OGA_PR_PATCHES` = `2685 2691 2705 2712 2792 2801`. Linux now also gets the extensions pin. ## Test plan - [x] Local: v0.17.0 + `pull/<n>.diff` of 2685 2691 2705 2712 2792 2801 applied with the CI `git apply --3way` command; Windows DML Release build; Qwen3.8-Flash-Next image description correct, 1024-token prefill / decode on par with the previous chain build. - [ ] Windows Build and Linux Build green. - [ ] Jenkins daily_hip_ep_genai on this PR: Qwen3.8 VLM output correct. ## Notes for reviewers The OGA cache key only contains PR numbers; updating #2801 does not invalidate it.
zz002
force-pushed
the
ci/oga-qwen38-patch-chain
branch
from
October 28, 2026 06:43
369950f to
0973974
Compare
Qwen3.8-Flash-Next needs the runtime in microsoft/onnxruntime-genai#2714, which is stacked on #2713 and on main changes made after v0.17.0. Add the 35 main PRs those diffs need, #2713, #2714 and #2782 (IndexerCache fix on top of #2714). Drop 2705, superseded by #2672 which is now in the list. Exclude Markdown from the applied diffs and retry .diff fetches on Windows.
## Summary Replace the 42-PR OGA patch list used for Qwen3.8-Flash-Next with the existing patches plus two: microsoft/onnxruntime-genai#2792 (onnxruntime-extensions pin with `Qwen3_5Tokenizer`) and microsoft/onnxruntime-genai#2801 (Qwen3.8 runtime from #2714 plus the IndexerCache fix #2782, ported onto v0.17.0). CI vehicle stacked on #1335; not for merge. ## Related issue or design Stacked on #1335. ## Why The previous list applied #2713/#2714 together with 35 OGA main PRs they depend on, which moved a large part of OGA past v0.17.0. #2801 ports only the Generator-path runtime onto v0.17.0, so the OGA used by CI stays close to the release. ## What - `windows-deps.yml`, `linux-build.yml`: `OGA_PR_PATCHES` = `2685 2691 2705 2712 2792 2801`. Linux now also gets the extensions pin. ## Test plan - [x] Local: v0.17.0 + `pull/<n>.diff` of 2685 2691 2705 2712 2792 2801 applied with the CI `git apply --3way` command; Windows DML Release build; Qwen3.8-Flash-Next image description correct, 1024-token prefill / decode on par with the previous chain build. - [ ] Windows Build and Linux Build green. - [ ] Jenkins daily_hip_ep_genai on this PR: Qwen3.8 VLM output correct. ## Notes for reviewers The OGA cache key only contains PR numbers; updating #2801 does not invalidate it.
BoarQing
added a commit
that referenced
this pull request
Nov 1, 2026
The Windows RMT build restores the OGA artifacts with fail-on-cache-miss, keyed by OGA_PR_PATCHES. #1335 changed the list in windows-deps.yml, which builds that cache, to "2685 2691 2705 2712 2792 2801", but windows-rmt.yml kept "2685 2691 2705 2712 2763", so its key matches no cache entry and the job fails at "Restore oga-artifacts" on main and every PR. Co-Authored-By: Cursor <cursoragent@cursor.com> Made-with: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build OGA v0.17.0 with the Qwen3.8-Flash-Next runtime: microsoft/onnxruntime-genai#2801 (the Generator-path runtime of #2714 plus the IndexerCache fix #2782, ported onto v0.17.0) and microsoft/onnxruntime-genai#2792 (onnxruntime-extensions pin with
Qwen3_5Tokenizer).Related issue or design
microsoft/onnxruntime-genai#2714, microsoft/onnxruntime-genai#2782, microsoft/onnxruntime-genai#2792, microsoft/onnxruntime-genai#2801
Why
The pinned OGA rejects the Qwen3.8
genai_config.json(Unknown value "rotary_position_ids"). #2714 adds that runtime but is based on OGA main after v0.17.0, so its diff does not apply to the tag alone. #2801 carries only the Generator-path part of #2714 (no Engine or CUDA changes) on top of v0.17.0, so no other main PRs are needed.What
OGA_PR_PATCHES(Windows and Linux):2685 2691 2705 2712 2792 2801.Qwen3_5Tokenizer). 2763 now merges OGA main into its branch, so its diff no longer applies on v0.17.0. Linux gets the pin too.*.mdfrom the applied diffs; the build does not read Markdown..difffetches (-MaximumRetryCount 6), as Linux already does with curl.Test plan
git apply --3waycommand (locally)gpu-test-package: image description correct; 1024-token prefill / decode on par with the earlier OGA build from #2714 plus its main dependenciesNotes for reviewers
The OGA cache key only contains PR numbers, so pushing new commits to #2792 or #2801 does not invalidate it.