Repository navigation
Conversation
|
Thanks for opening a PR! This project follows LLVM's incremental-development and AI-tool-use Before requesting review, please check that:
Reviewers are assigned through |
There was a problem hiding this comment.
🟡 Changes recommended
The revert reintroduces compiler failures, incorrect Split boundaries, and unsafe host access to device memory.
7 open issues
Allow singleton strides in contiguous view copies · New Use ceiling-based lengths for static-axis Split · New Validate Split outputs before creating IR · New Preserve LeakyRelu shape inference for ranked inputs · New Infer unknown Upsample dimensions from known shapes · New Prevent compiler abort for unranked Concat operands · New Restore ConvTranspose handling for unranked results · New
What changed in this PR
This PR reverts #1306 in hip-ep’s compiler, aiming to preserve stored dimensions by restricting shape inference to unranked results. It also restores earlier Split and memory-copy lowering behavior.
Changes:
- Removes ranked-result refinement and the LeakyRelu and ConvTranspose inference additions.
- Reverts omitted Split output handling and extent-one-aware copy detection.
- Removes corresponding regression tests and restores earlier pitched-copy fixtures.
| File | Description |
|---|---|
test/lit/Dialect/hip-infer-loop-body-shapes.mlir |
Removes Concat, ConvTranspose, and ranked Upsample regression cases. |
test/lit/Conversion/onnx-to-hip/test_split.mlir |
Removes omitted-output Split coverage. |
test/lit/Conversion/hip-to-llvm/test_memref_copy.mlir |
Removes singleton-copy cases and restores batch-one fixtures. |
lib/Dialect/Transforms/InferLoopBodyShapesPass.cpp |
Restores unranked-only inference and removes added rules. |
lib/Conversion/OnnxToHip/ReshapeConversion.cpp |
Restores earlier Split sizing and result handling. |
lib/Conversion/HipToLLVM/MemoryLowering.cpp |
Restores exact-stride checks for flat device copies. |
Review effort: Balanced
|
Not needed, fix for failing case present in PR-1336 |
L2 Accuracy Results (EP vs CPU)
Threshold: 0.01 | Run: 7973 - Commit: |
Binary sizesBaseline: run 40457802257 -
MorphiZen EP Performance Results
EPContext Export Performance
EPContext Import Performance
OGA Benchmark Results
OGA Wheel Smoke (Python benchmark_e2e.py)
VLM Benchmark Results
TTFT / TPS vs mainBaseline: run 40457802257 -
Run: 7973 - Commit: |

Summary
Test plan
hip-infer-loop-body-shapesLITtest_splitLITtest_memref_copyLITCursor assisted with the revert and this pull request.