rocfile: Move file inspection in DriverState::registerFile(...) into UnregisteredFile#12
Closed
kurtmcmillan wants to merge 1 commit into
Closed
rocfile: Move file inspection in DriverState::registerFile(...) into UnregisteredFile#12kurtmcmillan wants to merge 1 commit into
kurtmcmillan wants to merge 1 commit into
Conversation
kurtmcmillan
force-pushed
the
unregistered-file
branch
from
4ffa707 to
1c8b722
Compare
derobins
reviewed
Nov 4, 2025
| } | ||
| }; | ||
|
|
||
| class UnregisteredFile { |
Collaborator
There was a problem hiding this comment.
Do we want to try to maintain 1 class per file?
Collaborator
Author
There was a problem hiding this comment.
Good question. We already have multiple classes in file.cpp and buffer.cpp (FileMap, and BufferMap).
My rational for putting UnregisteredFile in file.cpp is that I'm (poorly) borrowing the typestate pattern from Rust. A file starts as a UnregisteredFile and becomes a (Registered)File when it is successfully registered. In other words, a UnregisteredFile is a File but with its "unregistered" status/flag indicated by its type.
Collaborator
Author
Collaborator
Author
|
This PR is from my private fork of hipFile. Unfortunately, our CI is not compatible with this workflow. Moving this PR to #14 which is a branch with this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.