Switch default CMake build mode to RelWithDebInfo#231
Conversation
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon and
zbyrne
as code owners
There was a problem hiding this comment.
Pull request overview
This PR changes the project’s default single-config CMake build type from Debug to RelWithDebInfo, and records the behavior change in the changelog.
Changes:
- Update the default
CMAKE_BUILD_TYPEtoRelWithDebInfowhen no build type is specified (single-config generators). - Add a changelog entry documenting the default build-type change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Switches the default CMAKE_BUILD_TYPE from Debug to RelWithDebInfo. |
| CHANGELOG.md | Documents the default CMake build-type change under “Changed”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
derobins
force-pushed
the
derobins/relwithdebinfo
branch
from
7780bf4 to
4c183e9
Compare
Changes from Debug
RelWithDebInfo emits warnings, so go back to Debug while we wait for fixes. When the fixes are in, the CI will be adapted to build both Debug and RelWithDebInfo.
derobins
force-pushed
the
derobins/relwithdebinfo
branch
from
4c183e9 to
c5f6f08
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /bin/bash -c " | ||
| cmake \ | ||
| -DCMAKE_CXX_COMPILER=g++ \ | ||
| -DCMAKE_CXX_FLAGS="-Werror" \ | ||
| -DCMAKE_HIP_PLATFORM=nvidia \ |
There was a problem hiding this comment.
The bash string passed to /bin/bash -c "..." is double-quoted, but -DCMAKE_CXX_FLAGS="-Werror" introduces an unescaped inner double quote. If this workflow is ever re-enabled, the command will be syntactically broken. Consider switching the outer -c string to single quotes (and avoiding host-side interpolation), or escaping the inner quotes / using single quotes around the -Werror value.
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
| -DCMAKE_CXX_COMPILER="${_AIS_INPUT_CXX_COMPILER}" \ | ||
| -DCMAKE_CXX_FLAGS="-Werror" \ | ||
| -DCMAKE_HIP_ARCHITECTURES="${{ env.AIS_HIP_ARCHITECTURES }}" \ |
There was a problem hiding this comment.
This workflow now forces -DCMAKE_BUILD_TYPE=Debug, which means CI no longer exercises the new default build type (RelWithDebInfo). If the intent of this PR is to move builds toward RelWithDebInfo, consider either using RelWithDebInfo here as well, or only using Debug conditionally (e.g., when AIS_USE_CODE_COVERAGE is enabled) so the default behavior stays validated in CI.
Changed from Debug