Skip to content

Fix include-what-you-use issues#30

Merged
derobins merged 14 commits into
developfrom
derobins/iwyu-fixes
Nov 7, 2025
Merged

Fix include-what-you-use issues#30
derobins merged 14 commits into
developfrom
derobins/iwyu-fixes

Conversation

@derobins
Copy link
Copy Markdown
Collaborator

@derobins derobins commented Nov 7, 2025

IWYU is generally quiet after this patch, aside from:

  • Google Test headers being declared local
  • One instance of mountinfo.h being declared a system header
  • IWYU wants to strip stdbool.h from hipfile.h and rocfile.h since it's running a C++ compiler

We can try to handle this later in a mapping file.

@derobins
Copy link
Copy Markdown
Collaborator Author

derobins commented Nov 7, 2025

Fun fact: hip/hip_runtime_api.h MUST come before hip/driver_types.h because the latter is not self-contained.

@derobins
Copy link
Copy Markdown
Collaborator Author

derobins commented Nov 7, 2025

FWIW, IWYU has a lot of bad ideas about C vs C++ and system vs local headers. It's not ready for being a GitHub CI action and we should definitely not use the auto-fix tool.

Copy link
Copy Markdown
Collaborator

@kurtmcmillan kurtmcmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If IWYU is not part of CI should we add a contributions guide stating that contributors should run IWYU for each commit?

@derobins derobins merged commit faad5d2 into develop Nov 7, 2025
32 checks passed
@derobins derobins deleted the derobins/iwyu-fixes branch November 10, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants