Fix include-what-you-use issues#30
Merged
Merged
Conversation
Collaborator
Author
|
Fun fact: |
Collaborator
Author
|
FWIW, IWYU has a lot of bad ideas about C vs C++ and system vs local headers. It's not ready for being a GitHub CI action and we should definitely not use the auto-fix tool. |
kurtmcmillan
approved these changes
Nov 7, 2025
Collaborator
kurtmcmillan
left a comment
There was a problem hiding this comment.
If IWYU is not part of CI should we add a contributions guide stating that contributors should run IWYU for each commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IWYU is generally quiet after this patch, aside from:
We can try to handle this later in a mapping file.