Remove the hipify patch#50
Merged
Merged
Conversation
We now direct people to the hipFile branch of our fork of ROCm/HIPIFY.
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the previously distributed hipify patch for hipFile, as users are now directed to use the hipFile branch of the ROCm/HIPIFY fork instead. This simplifies the distribution and maintenance approach.
- Removes the
hipfile_hipify.diffpatch file that was used to modify hipify to support cuFile to hipFile conversion - Removes the
hipfile/hipify/README.mdfile that contained instructions for applying the patch - Updates documentation in
introduction.rstto remove references to the patch
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hipfile/hipify/hipfile_hipify.diff | Removes the entire patch file (1051 lines) that added hipFile API support to hipify |
| hipfile/hipify/README.md | Removes the README with instructions for applying the hipify patch |
| hipfile/docs/introduction.rst | Removes documentation section about modifying CUDA code with the patch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordan-turbofish
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now direct people to the hipFile branch of our fork of ROCm/HIPIFY.