Rename util scripts to use hyphens#55
Merged
Merged
Conversation
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames utility scripts to use hyphens instead of underscores for consistency with standard shell script naming conventions. The changes introduce three utility scripts for FIO benchmarking, clang formatting, and source code linting.
- Addition of
iterate-fio-jobs.shfor running FIO benchmark jobs across different configurations - Addition of
full-clang-lint.shfor CI-based clang-format linting - Addition of
format-source.shfor formatting C/C++ source files
Reviewed Changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| util/iterate-fio-jobs.sh | Comprehensive script for iterating through FIO benchmark configurations and collecting results |
| util/full-clang-lint.sh | CI script to highlight clang-format issues and generate diffs |
| util/format-source.sh | Script to recursively format C/C++ source and header files using clang-format |
Comments suppressed due to low confidence (1)
util/format-source.sh:20
- The echo message references "bin/format_source" but the actual script name is "util/format-source.sh" (as indicated by the PR title). This documentation string should be updated to match the actual script path and name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
riley-dixon
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.