rocfile: Use statx to get direct io alignment and size requirements#62
Merged
Conversation
Collaborator
|
Are the Jenkins runners missing a package? |
kurtmcmillan
force-pushed
the
z/kumcmill/statx
branch
from
6258678 to
d21cba5
Compare
Collaborator
Author
No. STATX_DIOALIGN is only available since 6.1. Ubuntu 22, and possibly others, are still running with 5 series. I'll update the PR so that hipFile requires 4kib alignment if STATX_DIOALIGN isn't available. |
statx includes direct io alignment requirements and the device IDs for raw devices.
Adding statx data to file has made stat data redundant.
See statx (2) for more information.
kurtmcmillan
force-pushed
the
z/kumcmill/statx
branch
from
d21cba5 to
0367f5e
Compare
…1 Kernels If STATX_DIOALIGN is not available fallback to requiring IO size, file offset, and buffer offset to be multiples of 4KiB.
kurtmcmillan
force-pushed
the
z/kumcmill/statx
branch
from
0367f5e to
0c8aa39
Compare
kurtmcmillan
requested review from
derobins,
gaoikawa,
jordan-turbofish and
riley-dixon
as code owners
derobins
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.