Add some style guide verbiage#63
Conversation
derobins
commented
Nov 18, 2025
derobins
commented
- Headers
- C/C++ standards
- A few misc other things
* Headers * C/C++ standards * A few misc other things
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds essential style guide documentation to the project, establishing coding standards and conventions for the hipFile/rocFile codebase. The changes fill in previously empty sections with concrete guidelines for headers, language features, and shell scripts.
Key changes:
- Added header organization guidelines (include-what-you-use,
#pragma once, header ordering, Doxygen requirements) - Specified C++17 and C11 language standards with modern idiom requirements
- Added shell script standards (shellcheck, bash shebang, bash-isms)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
