Fix cmake-lint problems#65
Merged
Merged
Conversation
Collaborator
derobins
commented
Nov 19, 2025
- Add an rc file for running cmake-lint
- Currently just suppresses line length warnings
- Fix identified issues
- Add suppression comments for FetchContent format issues
Does not fix the FetchContent naming complaints as those are not something we control
The CMake linter does not like FooBar_BazWhat.
Collaborator
Author
|
The repo will be cmake-lint clean with these changes. When this goes in, I'll add a CI job to ensure it stays clean. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses cmake-lint warnings across the CMake build system by establishing linting standards and fixing identified issues. The changes ensure consistent code formatting and style compliance with cmake-lint rules while allowing exceptions for third-party FetchContent commands.
- Added
.cmakelintrcconfiguration file to suppress line length warnings - Fixed formatting issues including trailing whitespace, function declaration spacing, command casing, and indentation
- Added lint suppression comments for FetchContent blocks with mixed-case commands
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .cmakelintrc | New configuration file that suppresses line length warnings for cmake-lint |
| rocfile/src/CMakeLists.txt | Removed trailing whitespace after SYSINCLS parameter |
| cmake/AISUseROCmCMake.cmake | Added lint suppression comments around FetchContent_Declare/MakeAvailable blocks |
| cmake/AISUseGTest.cmake | Added lint suppression comments, blank line for readability, and fixed function declaration spacing |
| cmake/AISSetCoverageFile.cmake | Fixed function declaration spacing and changed MATH to lowercase math |
| cmake/AISSanitizers.cmake | Fixed function declaration spacing by removing space before parenthesis |
| cmake/AISInstall.cmake | Fixed indentation for rocm_install call to align with surrounding code |
| cmake/AISGNUCompilerOptions.cmake | Removed trailing whitespace after set(flags declaration |
| cmake/AISCompilerOptions.cmake | Fixed function declaration spacing by removing space before parenthesis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
jordan-turbofish
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.