Skip to content

Add a cmake-lint action #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
derobins wants to merge 5 commits into from
Closed

Add a cmake-lint action #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
500c465
Add a cmake-lint action
derobins Nov 19, 2025
b34734d
Add thirdparty to the codespell list
derobins Nov 19, 2025
74754aa
Fix yaml formatting
derobins Nov 19, 2025
98460a9
Add empty .cmake-format file
derobins Nov 19, 2025
e62879b
Pull .cmake-format file
derobins Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .codespellrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@
[codespell]
check-hidden = true
skip = ./.git
ignore-words-list = hsa,

# thirdparty is an option in the cmake-lint action
ignore-words-list = hsa,thirdparty
16 changes: 16 additions & 0 deletions .github/workflows/cmake-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Run cmake-lint over all our CMake files
# Includes CMakeLists.txt and all files in /cmake
Comment on lines +1 to +2
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment incorrectly describes the scope of directories being linted. It states "Includes CMakeLists.txt and all files in /cmake" but the actual source parameter includes many more directories: cmake, docs, hipfile, hipfile/src/amd_detail, hipfile/src/nvidia_detail, hipfile/test, rocfile, rocfile/src, and rocfile/test.

Consider updating the comment to accurately reflect what's being linted, for example:

# Run cmake-lint over all CMake files in the repository
# Includes root CMakeLists.txt and all files in cmake/, docs/, hipfile/, and rocfile/ directories
Suggested change
# Run cmake-lint over all our CMake files
# Includes CMakeLists.txt and all files in /cmake
# Run cmake-lint over all CMake files in the repository
# Includes root CMakeLists.txt and all files in cmake/, docs/, hipfile/, and rocfile/ directories

Copilot uses AI. Check for mistakes.
name: cmake-lint
on: pull_request
permissions:
contents: read
jobs:
format-check:
name: Run cmake-lint over CMake code
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493 #v4.1.7
- uses: neg-c/cmake-format-action@ba83660ac46d64c12ca96f39478dcde7680a52bf #v0.1
with:
source: ". cmake docs hipfile hipfile/src/amd_detail hipfile/src/nvidia_detail hipfile/test rocfile rocfile/src rocfile/test"
exclude: "thirdparty external"
Loading