Quiet clang-tidy about invalid enum values#69
Merged
Conversation
Only in test code
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Collaborator
Author
|
This eliminates almost all the clang-tidy output |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a NOLINT comment to suppress clang-tidy warnings in a test utility function that intentionally creates invalid enum values. The invalidEnum template function is designed to cast arbitrary integer values to enum types for testing error handling, which triggers static analysis warnings about out-of-range enum values.
Key Changes
- Added a
// NOLINTcomment to suppress clang-tidy warnings for the enum cast operation ininvalidEnumfunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordan-turbofish
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only in test code