Add additional clang flags#85
Merged
Merged
Conversation
-ftrivial-auto-var-init=pattern -Wmissing-noreturn -Wtautological-constant-in-range-compare -Wthread-safety-beta -Wthread-safety-negative -Wthread-safety-pointer -Wthread-safety-verbose
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances Clang compiler security and diagnostic capabilities by adding additional warning flags and initialization options. The changes focus on thread-safety analysis, automatic variable initialization, and enabling previously commented-out warnings.
Key changes:
- Added thread-safety warning flags (
-Wthread-safety-beta,-Wthread-safety-negative,-Wthread-safety-verbose,-Wthread-safety-pointer) - Enabled automatic variable initialization with pattern (
-ftrivial-auto-var-init=pattern) - Re-enabled
-Wmissing-noreturnwarning flag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
riley-dixon
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-ftrivial-auto-var-init=pattern
-Wmissing-noreturn
-Wtautological-constant-in-range-compare
-Wthread-safety-beta
-Wthread-safety-negative
-Wthread-safety-pointer
-Wthread-safety-verbose