Add AIS_BUILD_INTEGER_SANITIZERS#86
Merged
Merged
Conversation
derobins
requested review from
gaoikawa,
jordan-turbofish and
riley-dixon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for building with integer sanitizers, a Clang-specific feature that detects undefined integer behavior with minimal runtime overhead.
Key Changes:
- Added
AIS_BUILD_INTEGER_SANITIZERSCMake option for enabling integer sanitization - Implemented compiler check to ensure integer sanitizers are only enabled with Clang
- Updated documentation to include the new sanitizer option
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmake/AISSanitizers.cmake | Added integer sanitizer configuration with Clang compiler detection and appropriate flags |
| INSTALL.md | Added sanitizer options table documenting all three sanitizer build options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
I want to get this to pass, then switch it on all the time in debug builds. |
riley-dixon
reviewed
Nov 24, 2025
riley-dixon
reviewed
Nov 24, 2025
riley-dixon
approved these changes
Nov 24, 2025
kurtmcmillan
approved these changes
Nov 24, 2025
Adds an option to build integer sanitizers (clang-only)
derobins
force-pushed
the
derobins/integer_sanitizer
branch
from
5700f0e to
18523ed
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to build integer sanitizers (clang-only)