rocFile: Use platform-independent hoff_t#9
Merged
Merged
Conversation
Collaborator
derobins
commented
Nov 1, 2025
derobins
commented
- Move hoff_t definition to a new shared/hipfile-types.h file
- Use hoff_t everywhere in rocFile (except sys equivalents)
- Add hipfile-types.h to the list of installed files
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
jordan-turbofish
approved these changes
Nov 3, 2025
kurtmcmillan
approved these changes
Nov 3, 2025
* Move hoff_t definition to a new shared/hipfile-types.h file * Use hoff_t everywhere in rocFile (except sys equivalents) * Add hipfile-types.h to the list of installed files
derobins
force-pushed
the
derobins/hoff_t
branch
from
1ff39d2 to
cc65f86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.