Turn AIS_WARN_UNSAFE_BUFFER_OPS on by default#90
Merged
Conversation
This affects clang/llvm C++ only. We currently raise no warnings with this switched on. If it becomes problematic in the future, we can switch it back off, but it's useful to turn on to encourage developers to find other solutions if this raises warnings. This is only turned on by default w/ clang. For gcc, it remains off since it's not useful. It will now emit a FATAL_ERROR if enabled with gcc.
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables unsafe buffer operation warnings by default for Clang/LLVM C++ compilers while keeping them disabled for GCC. The change aims to proactively catch unsafe buffer usage patterns during development.
Key Changes:
- Set
AIS_WARN_UNSAFE_BUFFER_OPSto ON by default for Clang compilers - Add validation to prevent enabling the option with non-Clang compilers
- Update documentation to reflect the new default setting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmake/AISClangSafeBuffers.cmake | Add compiler detection logic to set default option value and validate compiler compatibility |
| INSTALL.md | Document the new default ON state for the buffer safety option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtmcmillan
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects clang/llvm C++ only. We currently raise no warnings with this switched on. If it becomes problematic in the future, we can switch it back off, but it's useful to turn on to encourage developers to find other solutions if this raises warnings.
This is only turned on by default w/ clang. For gcc, it remains off since it's not useful. It will now emit a FATAL_ERROR if enabled with gcc.