Skip to content

Remove hipFileGetBackendVersion()#91

Merged
derobins merged 1 commit into
developfrom
derobins/simplify_versioning
Nov 25, 2025
Merged

Remove hipFileGetBackendVersion()#91
derobins merged 1 commit into
developfrom
derobins/simplify_versioning

Conversation

@derobins
Copy link
Copy Markdown
Collaborator

This will not be necessary as we consolidate hipFile and rocFile.

This will not be necessary as we consolidate hipFile and
rocFile.
Copilot AI review requested due to automatic review settings November 25, 2025 16:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the hipFileGetBackendVersion() API function as part of consolidating hipFile and rocFile. The function provided backend library version information in a platform-specific integer format.

Key Changes:

  • Removed hipFileGetBackendVersion() function declaration from the public API header
  • Removed function implementations from both AMD and NVIDIA backend code paths
  • Removed all test coverage for the removed function

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hipfile/include/hipfile.h Removed API declaration and documentation for hipFileGetBackendVersion()
hipfile/src/nvidia_detail/hipfile.cpp Removed NVIDIA backend implementation of hipFileGetBackendVersion()
hipfile/src/amd_detail/hipfile.cpp Removed AMD backend implementation of hipFileGetBackendVersion()
hipfile/test/test-hipfile.cpp Removed test code that called hipFileGetBackendVersion()
hipfile/test/system/version.cpp Removed unit tests for hipFileGetBackendVersion()
hipfile/test/system/driver.cpp Removed test invocation of hipFileGetBackendVersion()
hipfile/docs/core.rst Updated documentation to remove backend version section and clarify version API usage
rocfile/docs/core.rst Updated documentation to describe the new signature of rocFileGetVersion() with individual version components

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@derobins derobins merged commit dac82fc into develop Nov 25, 2025
30 checks passed
@derobins derobins deleted the derobins/simplify_versioning branch November 25, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants