Remove hipFileGetBackendVersion()#91
Merged
Merged
Conversation
This will not be necessary as we consolidate hipFile and rocFile.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the hipFileGetBackendVersion() API function as part of consolidating hipFile and rocFile. The function provided backend library version information in a platform-specific integer format.
Key Changes:
- Removed
hipFileGetBackendVersion()function declaration from the public API header - Removed function implementations from both AMD and NVIDIA backend code paths
- Removed all test coverage for the removed function
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hipfile/include/hipfile.h | Removed API declaration and documentation for hipFileGetBackendVersion() |
| hipfile/src/nvidia_detail/hipfile.cpp | Removed NVIDIA backend implementation of hipFileGetBackendVersion() |
| hipfile/src/amd_detail/hipfile.cpp | Removed AMD backend implementation of hipFileGetBackendVersion() |
| hipfile/test/test-hipfile.cpp | Removed test code that called hipFileGetBackendVersion() |
| hipfile/test/system/version.cpp | Removed unit tests for hipFileGetBackendVersion() |
| hipfile/test/system/driver.cpp | Removed test invocation of hipFileGetBackendVersion() |
| hipfile/docs/core.rst | Updated documentation to remove backend version section and clarify version API usage |
| rocfile/docs/core.rst | Updated documentation to describe the new signature of rocFileGetVersion() with individual version components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtmcmillan
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will not be necessary as we consolidate hipFile and rocFile.