Remove BUILD_HIPFILE/ROCFILE#92
Conversation
These CMake options will be meaningless as we consolidate hipFile and rocFile. We will now always build both libraries on AMD and hipFile only on NVIDIA.
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
There was a problem hiding this comment.
Pull request overview
This PR removes the BUILD_HIPFILE and BUILD_ROCFILE CMake options as part of consolidating the hipFile and rocFile libraries. The new behavior builds both libraries on AMD platforms and only hipFile on NVIDIA platforms by default, without requiring explicit configuration options.
Key changes:
- Removed
BUILD_HIPFILEandBUILD_ROCFILECMake options - Simplified build logic to always build hipFile and conditionally build rocFile based on platform
- Updated documentation and CI workflows to reflect the simplified build configuration
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Removed CMake options and simplified platform-based build logic |
| cmake/AISInstall.cmake | Removed conditional guards around hipFile installation and updated package description |
| docs/CMakeLists.txt | Removed conditional guards around hipFile docs target |
| INSTALL.md | Removed BUILD_HIPFILE and BUILD_ROCFILE option documentation |
| .github/workflows/hipfile-nvidia.yml.disabled | Removed obsolete CMake flags from CI configuration |
| .github/workflows/build-ais.yml | Removed obsolete CMake flags from CI configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
This looks like big changes, but it's the diff algorithm being confused by removing the if() and shifting everything over to the left + a few minor tweaks.
| #----------------------- | ||
| # aiscp example program | ||
| #----------------------- | ||
| option(BUILD_AISCP "Build aiscp example program" ON) |
There was a problem hiding this comment.
When we have more examples, we should just change this to BUILD_EXAMPLES.
These CMake options will be meaningless as we consolidate hipFile and rocFile. We will now always build both libraries on AMD and only hipFile on NVIDIA.