CI: Update container names#93
Merged
riley-dixon merged 3 commits intoNov 26, 2025
Merged
Conversation
riley-dixon
requested review from
derobins,
gaoikawa,
jordan-turbofish and
kurtmcmillan
as code owners
Note: Replaces '+' with 'plus' to make it safe for Docker to use. Docker does not like most non-alphanumeric characters when it comes to naming containers. On a self-hosted machine with multiple CI runners, this could cause matrix jobs to create a container with the same name. (Matrix jobs do not modify job_id.) This change was introduced when we moved to GitHub provided runners. So while we have not hit this issue, we should still fix it. Also makes some cosmetic changes to come container names like dropping a redundant "_nvidia" suffix.
riley-dixon
force-pushed
the
rildixon/ci-fix-container-name
branch
from
24e42b3 to
dc34f37
Compare
kurtmcmillan
approved these changes
Nov 26, 2025
…ldixon/ci-fix-container-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't an issue on isolated runners, but on a host with multiple runners could induce a conflict in Docker with trying to start a container with the same name as an existing container. This would only occur on matrix jobs since the matrix parameter is not actually added to the
job_id. I don't believe we ever hit this issue however since this was introduced as we switched away from self-hosted machines.