amd-staging: Remove sram_ecc_legacy flags#3059
Merged
chinmaydd merged 1 commit intoJul 10, 2026
Merged
Conversation
Author
|
ping |
jhuber6
approved these changes
Jul 7, 2026
Base automatically changed from
arsenm/openmp-upstream-divergence-getAMDGPUTargetFeatures-signature
to
amd-staging
July 8, 2026 06:44
Author
|
@skganesan008 is this one stuck like #3057 was? |
Collaborator
|
yes @arsenm, this was due to external github server issue(s). They have resolved the issue. Closing and reopening this PR should help verify the PR. I saw Chinmay already did that. |
These are not upstream, have no tests and have old comments to remove them. Additionally, upstream recently re-added a non-legacy name for the same purpose.
arsenm
force-pushed
the
arsenm/openmp-divergence-remove-sram_ecc_legacy-flags
branch
from
24574c0 to
8072cc9
Compare
chinmaydd
deleted the
arsenm/openmp-divergence-remove-sram_ecc_legacy-flags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not upstream, have no tests and have old comments to remove them. Additionally, upstream recently re-added a non-legacy name for the same purpose.