[CI][Security] ROCM-26573: Move secrets from argv to env variables#3113
Open
vkallesh wants to merge 1 commit into
Open
[CI][Security] ROCM-26573: Move secrets from argv to env variables#3113vkallesh wants to merge 1 commit into
vkallesh wants to merge 1 commit into
Conversation
…ables
Fix for ROCM-26573 - Plaintext HTTP Auth Token Transmission and Secrets
Exposed on Process argv
Issue: buildbot-psdb-trigger.yml and compute-rocm-dkmd-afar-trigger.yml
pass secrets directly on the shell command line (argv), making them
visible to any process that can read /proc/<pid>/cmdline or tools like
ps, top, htop. Additionally, Buildbot API calls used HTTP instead of
HTTPS, exposing credentials to network observers.
Impact: Secrets (BUILDBOT_USER, BUILDBOT_PWD, CI_JENKINS_TOKEN) are
visible in process listings, shell history, and system monitoring tools.
HTTP transmission allows MITM attacks and credential interception.
Fix:
1. Move all secrets from argv to env: blocks
2. Pass secrets to docker containers via -e flags
3. Access secrets via $ENV_VAR in shell, os.environ in Python
4. Change all Buildbot HTTP URLs to HTTPS (lines 86, 93)
5. Remove echo of BUILDBOT_HOST:PORT (information disclosure)
Files modified:
- .github/workflows/buildbot-psdb-trigger.yml
* Moved BUILDBOT_USER, BUILDBOT_PWD, BUILDBOT_HOST, BUILDBOT_WORKER_PORT to env:
* Changed http:// to https:// for Buildbot API calls
* Removed echo of secrets
- .github/workflows/compute-rocm-dkmd-afar-trigger.yml
* Moved CI_JENKINS_USER, ROCM_JENKINS_CI_TOKEN to env:
* Access via os.environ[] instead of workflow substitution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://amd-hub.atlassian.net/browse/ROCM-26573 - Plaintext HTTP Auth Token Transmission and Secrets Exposed on Process argv