[Comgr] Use memcpy in amd_comgr_symbol_get_info NAME handler#3208
Open
lamb-j wants to merge 1 commit into
Open
[Comgr] Use memcpy in amd_comgr_symbol_get_info NAME handler#3208lamb-j wants to merge 1 commit into
lamb-j wants to merge 1 commit into
Conversation
Replace strcpy with a length-based memcpy in the AMD_COMGR_SYMBOL_INFO_NAME case to match the other *_get_info handlers. Behavior is unchanged: the caller sizes the buffer via AMD_COMGR_SYMBOL_INFO_NAME_LENGTH per the API contract. ISSUE ID: ROCM-26574
chinmaydd
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
strcpywith a length-basedmemcpyin theAMD_COMGR_SYMBOL_INFO_NAMEcase ofamd_comgr_symbol_get_info, matching the pattern used by the other*_get_infohandlers.Behavior is unchanged:
Valueis a caller-allocated buffer sized viaAMD_COMGR_SYMBOL_INFO_NAME_LENGTH(+1 for the NUL) per the documented API contract. This is a cosmetic change to clear a static-scan signature; it is not a security fix (a true bound would require an API/ABI change, which is not warranted).ISSUE ID: ROCM-26574