Skip to content

[hipblaslt] Remove unused include (immintrin.h)#9293

Open
benrichard-amd wants to merge 1 commit into
developfrom
users/benrichard-amd/hipblaslt-unused-header
Open

[hipblaslt] Remove unused include (immintrin.h)#9293
benrichard-amd wants to merge 1 commit into
developfrom
users/benrichard-amd/hipblaslt-unused-header

Conversation

@benrichard-amd

Copy link
Copy Markdown
Contributor

Motivation

This PR removes an unused x86 header, immintrin.h. Removing improves ROCm code portability portability(ROCm/TheRock#5518)

Technical Details

immintrin.h is included but nothing from it is ever used.

Test Plan

Build hipblaslt and run tests

Test Result

Build and tests run successfully on gfx942

Submission Checklist

  • [ * Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

@benrichard-amd benrichard-amd requested a review from a team as a code owner July 10, 2026 20:41
@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hipblaslt/clients/common/include/hipblaslt_math.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.84%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9293   +/-   ##
========================================
  Coverage    65.07%   65.07%           
========================================
  Files         2685     2685           
  Lines       422262   422262           
  Branches     62741    62741           
========================================
  Hits        274750   274750           
  Misses      126793   126793           
  Partials     20719    20719           
Flag Coverage Δ *Carryforward flag
TensileLite 35.05% <ø> (ø) Carriedforward from a2799c7
hipBLAS 90.81% <ø> (ø) Carriedforward from a2799c7
hipBLASLt 34.69% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from a2799c7
hipDNN 86.12% <ø> (ø) Carriedforward from a2799c7
hipFFT 50.88% <ø> (ø) Carriedforward from a2799c7
hipRAND 76.12% <ø> (ø) Carriedforward from a2799c7
hipSOLVER 69.18% <ø> (ø) Carriedforward from a2799c7
hipSPARSE 86.10% <ø> (ø) Carriedforward from a2799c7
rocBLAS 47.91% <ø> (ø) Carriedforward from a2799c7
rocFFT 51.65% <ø> (ø) Carriedforward from a2799c7
rocRAND 57.02% <ø> (ø) Carriedforward from a2799c7
rocSOLVER 76.84% <ø> (ø) Carriedforward from a2799c7
rocSPARSE 72.37% <ø> (ø) Carriedforward from a2799c7
rocThrust 91.36% <ø> (ø) Carriedforward from a2799c7

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ipblaslt/clients/common/include/hipblaslt_math.hpp 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants