docs(rfc): extend RFC 0015 engine support claims for bundle sweeps#9296
Draft
adickin-amd wants to merge 2 commits into
Draft
docs(rfc): extend RFC 0015 engine support claims for bundle sweeps#9296adickin-amd wants to merge 2 commits into
adickin-amd wants to merge 2 commits into
Conversation
Add per-case support claims for RFC 0011 template-sweep bundles: a co-located support.json keyed engine-first, then grouped by shared support footprint (cases + supported arch/platforms), so a common set and outliers compress cleanly. Drop the unsupported verdict in favor of presence-based supported claims (absence = not enforced), and restore the end-of-run unclaimed-support summary for claim-bearing bundles.
github-actions
Bot
added
documentation
ci:docs-only
adickin-amd
commented
Jul 10, 2026
| |------------|-----------------| | ||
| | A graph that a bundle claims `supported` loses engine support for a claimed `(engine, arch, platform)`. | The claimed engine is *declined* — absent from the resolved support query's ranked list (`GRAPH_NOT_SUPPORTED` when it is the sole/last engine) → **FAIL** (replaces the silent `GTEST_SKIP`). See §5.2 / §7.1 for how "declined" is distinguished from "errored". | | ||
| | A graph with a `supported` claim hits an unresolved query (build failure, infrastructure fault) before its verdict can be evaluated. | The claim could not be assessed → **FAIL** ("errored before the claim could be checked; fix the error first"). Distinct from the *declined* verdict above, which is the real-regression case. | | ||
| | A graph claimed `unsupported` unexpectedly becomes supported. | Live support query returns supported → **note** ("claimed support != actual support"), not a failure. | |
Contributor
Author
There was a problem hiding this comment.
i removed this because there is no point in putting unsupported in the files. if its absent, its not supported.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Condense the sweep-related prose without changing any rules: merge the discovery/claim-key bullets, drop duplicated 'no new mechanism' and preservation wording shared with 9.2, and fold 5.4's engine-key and claim-group bullets together.
adickin-amd
commented
Jul 10, 2026
| "MIOPEN_ENGINE": { | ||
| "gfx942": { "linux": "supported", "windows": "supported" }, | ||
| "gfx90a": { "linux": "unsupported" } | ||
| "gfx942": ["linux", "windows"], |
Contributor
Author
There was a problem hiding this comment.
I think I like this better, going to keep this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends RFC 0015: Per-Graph Engine Support Claims to cover the template-sweep ("bundle sweep") bundles introduced by RFC 0011, so support claims can attach per sweep case rather than only per single-graph bundle. This unblocks pinning engine-support contracts for sweep-defined graphs, which the integration-test suite already exercises today.
JIRA ID : ALMIOPEN-2303
Risk Assessment
Minimal risk. Documentation-only change to a single RFC markdown file; no product code, build configuration, public API, schema, or tests are affected.
Testing Summary
Testing Checklist
Technical Changes
{Name}.jsonbundles and template-sweep cases expanded fromgraph.template.jsonviasweep.json(§1, §4).support.json: keyed engine-first, then an array of{ cases, support }groups so a common support footprint compresses across many cases with outliers as separate entries; case ids must exist insweep.json, each claimed at most once per engine.unsupportedverdict in favor of presence-basedsupportedclaims (platform lists per arch); absence uniformly means "not enforced," never "asserted-declined."enforcement_levellocation (per-casecases[].metadata), the write tool (flatten→overlay→regroup canonical writes), pre-commit validation, support-matrix rendering, and the CI observation harvest (§4, §6, §9, §11, §12, §16).