feat(ci): Allow commas in PR titles#9297
Open
umfranzw wants to merge 1 commit into
Open
Conversation
Currently, the libraries pr-bot does not allow commas in PR titles. In primitives libraries PRs, we sometimes touch multiple libraries in in same PR. It would be useful to be able to list them all (in a comma- delimited fashion) instread of just the first one. Eg. "fix(hipcub,rocprim) title text..." This change modifies the pr bot's regex to allow commas between the parenthesis.
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the libraries pr-bot does not allow commas in PR titles.
In primitives libraries PRs, we have libraries that are dependent on each other,
so sometimes it's useful (or just convenient) to modify multiple libraries in the
same PR (eg. #8439).
Prior to the introduction of the pr-bot, in cases like this, in the PR title, we had been
separating the library names with commas.
Eg. "fix(hipcub,rocprim) title text..."
Technical Details
This change modifies the pr bot's regex to allow commas between the parenthesis.
Test Plan
Run the updated bot on a PR that has commas between the parenthesis in the title.
Test Result
TBD - will test as soon as I'm able.
Submission Checklist