Skip to content

feat(ci): Allow commas in PR titles#9297

Open
umfranzw wants to merge 1 commit into
developfrom
users/umfranzw/update_pr_bot_title_regex
Open

feat(ci): Allow commas in PR titles#9297
umfranzw wants to merge 1 commit into
developfrom
users/umfranzw/update_pr_bot_title_regex

Conversation

@umfranzw

Copy link
Copy Markdown
Contributor

Motivation

Currently, the libraries pr-bot does not allow commas in PR titles.
In primitives libraries PRs, we have libraries that are dependent on each other,
so sometimes it's useful (or just convenient) to modify multiple libraries in the
same PR (eg. #8439).
Prior to the introduction of the pr-bot, in cases like this, in the PR title, we had been
separating the library names with commas.
Eg. "fix(hipcub,rocprim) title text..."

Technical Details

This change modifies the pr bot's regex to allow commas between the parenthesis.

Test Plan

Run the updated bot on a PR that has commas between the parenthesis in the title.

Test Result

TBD - will test as soon as I'm able.

Submission Checklist

Currently, the libraries pr-bot does not allow commas in PR titles.
In primitives libraries PRs, we sometimes touch multiple libraries in
in same PR. It would be useful to be able to list them all (in a comma-
delimited fashion) instread of just the first one.
Eg. "fix(hipcub,rocprim) title text..."

This change modifies the pr bot's regex to allow commas between the
parenthesis.
@github-actions github-actions Bot added the project: none Does not target any component label Jul 10, 2026
@umfranzw umfranzw requested a review from amd-shiraz July 10, 2026 21:34
@therock-pr-bot

therock-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@umfranzw umfranzw changed the title feat(ci) Allow commas in PR titles feat(ci): Allow commas in PR titles Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant