[ROCCLR] Mark VirtualMapCommand event complete after synchronous submit#6594
Open
BertanDogancay wants to merge 1 commit into
Open
[ROCCLR] Mark VirtualMapCommand event complete after synchronous submit#6594BertanDogancay wants to merge 1 commit into
BertanDogancay wants to merge 1 commit into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes a distributed deadlock in hipMemMap() / hipMemUnmap() that hangs RCCL multi-segment IPC registration at ≥ 8 ranks.
Technical Details
The fix is in
VirtualGPU::submitVirtualMap(): mark the command's event CL_COMPLETE immediately afterHsa::vmem_map / Hsa::vmem_unmapreturn HSA_STATUS_SUCCESS, and CL_INVALID_OPERATION on failure. This causes the subsequentEvent::awaitCompletion()short-circuit at thestatus() > CL_COMPLETEcheck, so the Marker is never enqueued and the entire deadlock-forming code path disappears for both APIs.JIRA ID
ROCM-25387
Test Plan
rccl-UnitTestsMPI UMR_MultiSegment tests up to 8 ranks.
Test Result
Pass / No hangs
Submission Checklist