[WIP][ROCm] Fix stale symbol names in tsan_ignore_list.txt#1032
Open
nurmukhametov wants to merge 3 commits into
Open
[WIP][ROCm] Fix stale symbol names in tsan_ignore_list.txt#1032nurmukhametov wants to merge 3 commits into
nurmukhametov wants to merge 3 commits into
Conversation
Both //build_tools/rocm:sanitizer_wrapper and :parallel_gpu_execute can end up as the effective --run_under tool depending on --config order (--run_under is single-valued, so tsan/asan and ci_single_gpu/ ci_multi_gpu/ci_rocm_cpu silently clobber each other), so both need to resolve the symbolizer correctly.
Several suppressions no longer matched their target races after upstream renames/removals, silently letting TSan reports through: AllocateAndRecordEvent moved from PjRtStreamExecutorClient to LocalDeviceState (edaa01b), ExecuteHelper was migrated to CommonPjRtLoadedExecutable::ExecuteHelperOnSingleDevice (d300770), HloRunnerPjRt was renamed to HloRunner (a15d305), and AllocateDestinationBuffer/BufferFromHostBufferInternal were deleted outright (3cf1f09).
nurmukhametov
added
sanitizers
nurmukhametov
added
sanitizers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Several suppressions no longer matched their target races after
upstream renames/removals, silently letting TSan reports through.
Submission Checklist