Repository navigation
test(web): fix flaky 'Map shown.' announcement test - #124
Merged
Merged
Conversation
The test waited only for fetchCorridorFeatures to be called. The resolved corridor promise then announced "N listed along your route." through the single live region, sometimes after the toggle click, replacing "Map shown." Wait for the corridor announcement before clicking. Surfaced on dependabot PR #122 (uv.lock-only change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RSid
marked this pull request as ready for review
October 8, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanExperience > announces 'Map shown.' …is flaky. It failed CI on the dependabot mako bump (#122), which only changesuv.lock.The test waited only for
fetchCorridorFeaturesto be called. After the promise resolved,announce("N listed along your route.")went out through the single live region, sometimes after the toggle click.AnnounceProviderkeeps only the latest message, so the corridor text replaced "Map shown." The test now waits for the corridor announcement to appear before it clicks.Tickets closed
chore: no ticket (test reliability)
Decisions touched
None
Tests added or changed
apps/web/components/PlanExperience.test.tsx: changed what the test waits on before clicking. Assertions are unchanged.Mocks introduced
None
Out of scope
@dependabot rebase.🤖 Generated with Claude Code