Skip to content

test(web): fix flaky 'Map shown.' announcement test - #124

Merged
RSid merged 1 commit into
mainfrom
fix/flaky-map-shown-test
Oct 8, 2026
Merged

RSid merged 1 commit into
mainfrom
fix/flaky-map-shown-test

Conversation

@RSid

@RSid RSid commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

PlanExperience > announces 'Map shown.' … is flaky. It failed CI on the dependabot mako bump (#122), which only changes uv.lock.

The test waited only for fetchCorridorFeatures to be called. After the promise resolved, announce("N listed along your route.") went out through the single live region, sometimes after the toggle click. AnnounceProvider keeps only the latest message, so the corridor text replaced "Map shown." The test now waits for the corridor announcement to appear before it clicks.

Tickets closed

chore: no ticket (test reliability)

Decisions touched

None

Tests added or changed

  • apps/web/components/PlanExperience.test.tsx: changed what the test waits on before clicking. Assertions are unchanged.
  • Locally: the file passed 8 runs in a row, the full web unit suite passed (189 tests), and eslint and tsc are clean.

Mocks introduced

None

Out of scope

🤖 Generated with Claude Code

The test waited only for fetchCorridorFeatures to be called. The resolved
corridor promise then announced "N listed along your route." through the
single live region, sometimes after the toggle click, replacing
"Map shown." Wait for the corridor announcement before clicking.

Surfaced on dependabot PR #122 (uv.lock-only change).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RSid
RSid marked this pull request as ready for review October 8, 2026 16:45
@RSid
RSid merged commit 6f50049 into main Oct 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant