Skip to content

Михалев Кирилл#14

Open
Foxovsky-bit wants to merge 1 commit into
RTF-Angular-2021:masterfrom
Foxovsky-bit:change
Open

Михалев Кирилл#14
Foxovsky-bit wants to merge 1 commit into
RTF-Angular-2021:masterfrom
Foxovsky-bit:change

Conversation

@Foxovsky-bit
Copy link
Copy Markdown

5 заданий

Comment thread src/task_1/index.ts
const RU = [10, 50, 100, 500, 1000, 5000];
let countCopy = count;

for (let banknote of this._repository) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это не жадный алгоритм

Comment thread src/task_5/index.ts
public takeUsersMoney(moneyUnits: any): any {

public takeUsersMoney(moneyUnits: IMoneyUnit): void {
this._moneyRepository.takeMoney(moneyUnits);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нет проверки на авторизацию

Comment thread src/task_5/index.ts
public giveOutUsersMoney(count: any): any {

public giveOutUsersMoney(count: number): void {
this._moneyRepository.giveOutMoney(count, this._authorizedUser.cards[0]['currency']);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нет проверки на авторизацию

Comment thread src/task_5/index.ts
public changeAuthorizedUserSettings(option: UserSettingOptions, argsForChangeFunction: any): any {

public changeAuthorizedUserSettings(option: UserSettingOptions, argsForChangeFunction: string): void {
this._userSettingsModule.changeUserSettings(option, argsForChangeFunction);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нет проверки на авторизацию

Comment thread src/task_5/index.ts
public convertMoneyUnits(fromCurrency: Currency, toCurrency: Currency, moneyUnits: any): any {

public convertMoneyUnits(fromCurrency: Currency, toCurrency: Currency, moneyUnits: IMoneyUnit): void {
this._currencyConverterModule.convertMoneyUnits(fromCurrency, toCurrency, moneyUnits);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нет проверки на авторизацию

Comment thread src/task_4/index.ts
if (this._moneyRepository.giveOutMoney(moneyUnits.count * denomination, toCurrency))
return moneyUnits.count * denomination * 70;

}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 бала

Comment thread src/task_3/index.ts
}
else
return this.registerForUserNewCard(argsForChangeFunction);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 бала

Comment thread src/task_2/index.ts
if (card.id === cardId)
return true;
}
return false;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 бала

Comment thread src/task_1/index.ts

public giveOutMoney(count: any, currency: any): any {
public giveOutMoney(count: number, currency: Currency): boolean {
const US = [1, 2, 5, 10, 20, 50, 100];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Эти купюры находятся в массиве private _repository: Array;

Comment thread src/task_1/index.ts
public takeMoney(moneyUnits: any): any {

public takeMoney(moneyUnits: IMoneyUnit): void {
this._repository.push(moneyUnits);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 балов

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants