Дюкин Петр // ts-2#7
Open
diukin wants to merge 3 commits into
Open
Conversation
added 2 commits
April 8, 2021 14:46
Toouren
reviewed
Apr 14, 2021
| export class MoneyRepository { | ||
| private _repository: any; | ||
| constructor(initialRepository: any) { | ||
| private _repository: Array<object>; |
Contributor
There was a problem hiding this comment.
Object в типизации - страшный грех, также как и any
Toouren
reviewed
Apr 14, 2021
| const rubles = [10, 50, 100, 500, 1000, 5000]; | ||
| this._repository.forEach(e => { | ||
| for (let key in e) | ||
| if (e['moneyInfo']['currency'] === currency && temp >= e['count'] |
Contributor
There was a problem hiding this comment.
Обращаться к объекту через скобки и строчную нотацию следует только в одном случае - когда название поля состоит из нескольких слова, но это полная жесть и так никто не делает
Toouren
reviewed
Apr 14, 2021
| public changeUserSettings(option: UserSettingOptions, argsForChangeFunction: any): any { | ||
|
|
||
| public changeUserSettings(option: UserSettingOptions, argsForChangeFunction: string): boolean { | ||
| return argsForChangeFunction === option[0] ? this.changeUserName(argsForChangeFunction) : |
Contributor
There was a problem hiding this comment.
Одно тернарное выражение в другом тернарном выражении очень запутывает, не надо так
Toouren
reviewed
Apr 14, 2021
| public convertMoneyUnits(fromCurrency: Currency, toCurrency: Currency, moneyUnits: any): any { | ||
|
|
||
| public convertMoneyUnits(fromCurrency: Currency, toCurrency: Currency, moneyUnits: IMoneyUnit[]): IMoneyUnit[] { | ||
| const K = fromCurrency === Currency.RUB ? 70 : 1/70; |
Contributor
There was a problem hiding this comment.
Математика в компьютере работает не так как в обычной жизни.
Когда условие попадет во вторую часть тернарного выражения коэффициент будет равен 0.014285714285714285 что сразу сломает все дальнейшие вычисления
Toouren
reviewed
Apr 14, 2021
| public convertMoneyUnits(fromCurrency: Currency, toCurrency: Currency, moneyUnits: IMoneyUnit[]): IMoneyUnit[] { | ||
| const K = fromCurrency === Currency.RUB ? 70 : 1/70; | ||
| let res: IMoneyUnit[] = []; | ||
| for (var e of moneyUnits) { |
Contributor
There was a problem hiding this comment.
Для обхода массива следует использовать методы объекта массива
Toouren
reviewed
Apr 14, 2021
| if (!this._authorizedUser) return false; | ||
| this._moneyRepository.takeMoney(moneyUnits); | ||
| const sum = moneyUnits.reduce((sum, unit) => { | ||
| return sum + unit.count * (+unit.moneyInfo.denomination.match(/\d/g).join(''));}, 0); |
Contributor
There was a problem hiding this comment.
Неявное преобразование - зло
m-abrosimov
reviewed
May 20, 2021
| else this._repository.push(unit); | ||
| }) | ||
| } | ||
| } No newline at end of file |
| if (typeof user === "undefined") return false | ||
| card = user.cards.filter(x => x.id === cardId)[0]; | ||
| return typeof card !== "undefined" ? cardPin === card.pin : false; | ||
| } |
| case UserSettingOptions.surname: | ||
| return this.changeUserSurname(argsForChangeFunction); | ||
| } | ||
| } |
| return moneyUnits.count * denomination * 70; | ||
| } | ||
| return 0; | ||
| } |
| if (this._authorizedUser) | ||
| return Boolean(this._currencyConverterModule.convertMoneyUnits(fromCurrency, toCurrency, moneyUnits)); | ||
| return false; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.