Melanin Nikita#28
Open
NikitaMelanin wants to merge 5 commits into
Open
Conversation
added 3 commits
October 4, 2021 20:33
loozmax
reviewed
Oct 5, 2021
| return date >= this.vacationStartDate && date <= this.vacationEndDate; | ||
|
|
||
| } | ||
| }; |
| */ | ||
|
|
||
| function Organaizer(meetings = [], vacations = []) { | ||
| this.meetings = meetings; |
Author
There was a problem hiding this comment.
У нас же указано, что поступает: "массив данных", зачем делать проверку?
There was a problem hiding this comment.
Затем, что мне ничего не запрещает прокинуть туда что-то иное.
loozmax
reviewed
Oct 5, 2021
| */ | ||
| function Time(hours, minutes) { | ||
| } | ||
| if (hours < 0 || hours > 24 || minutes < 0 || minutes > 60) { |
Author
There was a problem hiding this comment.
А так разве изначально не понятно, что будет введено число?
| */ | ||
| function Meeting(meetingDate, startTime, endTime) { | ||
| } | ||
| if (startTime.hours < 8 || endTime.hours > 19 || startTime > endTime){ |
| this.endTime = endTime; | ||
| }; | ||
| Meeting.prototype.isMeetingInTimeRange = function(start, end) { | ||
| return start.isEarlier(this.endTime) && end.isLater(this.startTime); |
|
В принципе ок, поправь замечания |
loozmax
reviewed
Oct 9, 2021
| */ | ||
| function Meeting(meetingDate, startTime, endTime) { | ||
| } | ||
| const {Time} = require("../task-1"); |
| */ | ||
|
|
||
| function Organaizer(meetings = [], vacations = []) { | ||
| if(!Array.isArray(meetings) && !Array.isArray(vacations)) { |
There was a problem hiding this comment.
Необходимо сделать проверку, что массив meetings принадлежит инстансу класса Meeting, а vacations инстанс Vacation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.