adds cbrfc_wsv_esp data to local warehouse for crmms test locations - #67
Open
samland1116 wants to merge 2 commits into
Open
adds cbrfc_wsv_esp data to local warehouse for crmms test locations#67samland1116 wants to merge 2 commits into
samland1116 wants to merge 2 commits into
Conversation
Contributor
|
Mostly same comments at #68 Overall I think we need to coordinate the secondary IDs, crosswalks and variable names. I also think we want to keep things split up so domain adding code separate from fetching code, etc. but we can evolve the process as we go as long as we commit to doing so and continuing to refactor. Just a note - don't need to address here: Some of this code loading the domains, locations, crosswalks, etc. is really data migrations (vs database schema migrations) - ultimately, we probably need to figure out a better pattern for handling "data migrations" which seems to be a pain point across many projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures the
warehouse/localdir to include autilsfolder to store thesetup_utils.pyand any other ingest specific utils. These utils will move to a prefect workflow but are stored here temporarily to avoid blocking progress on frontend-developmentCBRFC WSV ESP Test Data:
Will transition into prefect workflow as opposed to this scratch-work implementation once we have the full locations list
Closes #20