fix: prevent overwriting device result dicts#112
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a bug where helper functions extracting results from the central optimization overwrote per-device result dicts (e.g., HP) that had already been populated with data like COP and Q_th by earlier extraction steps. The fix preserves existing keys by only initializing the device dict when not already present.
Changes:
- Replace unconditional
results_dict[n][device] = {}with conditional initialization in four locations (heat, cooling, power, storage devices) withinhelper_func_extract_eh_results.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #111