Skip to content

Wait for url to be ready with progress bar#19

Merged
larencozart merged 6 commits intomainfrom
laren/add-wait-for-url
Apr 1, 2025
Merged

Wait for url to be ready with progress bar#19
larencozart merged 6 commits intomainfrom
laren/add-wait-for-url

Conversation

@larencozart
Copy link
Copy Markdown
Contributor

  • Added a waitForAppToBeReady file
  • This file polls our url, and waits for a 200 response, displaying a progress bar while the user waits

To test this:

  1. Just in case, delete your node_modules
  2. Run npm install
  3. Run npm run build
  4. Run node dist/cli/cli.js destroy
  5. Run node dist/cli/cli.js deploy

@larencozart larencozart requested a review from a team April 1, 2025 16:06
@larencozart larencozart merged commit 26e2f91 into main Apr 1, 2025
3 checks passed
Copy link
Copy Markdown
Contributor

@jq-ln jq-ln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress bar is duplicated when screen is re-sized, but that can be figured out later. Otherwise, everything works well!

@jq-ln jq-ln deleted the laren/add-wait-for-url branch April 1, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants